build!: remove jsonrpc feature flag #6417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
approved these changes
Jan 8, 2025
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
The commit message needs to be improved:
build(ffi)!: remove jsonrpc feature flag
It is enabled everywhere by default since some time now. Breaking, because existing build scripts might need to be adjusted.
Simon-Laux
changed the title
link2xt
approved these changes
Jan 9, 2025
It is enabled everywhere by default since some time now. Breaking, because existing build scripts might need to be adjusted.
link2xt
force-pushed
the
simon/remove-jsonrpc-feature-from-ffi
branch
from
e402b34 to
b377ec2
Compare
Hocuri
added a commit
to deltachat/deltachat-android
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #6326 (comment)