fix: Make calc_sort_timestamp() a continuous function of message timestamp
#7180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
2 times, most recently
from
a7ef844 to
fe2e94c
Compare
iequidoo
changed the base branch from
iequidoo/test_sync_sentbox_then_inbox
to
main
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
from
fe2e94c to
8c77e2a
Compare
…mestamp This also simplifies the SQL query in `calc_sort_timestamp()` and prepares for creation of a db index for it so that it's fast. Currently it doesn't uses indexes effectively; if a chat has many messages, it's slow, i.e. O(n). This as well fixes ordering of delayed encrypted outgoing messages; before, they could be sorted above "Messages are end-to-end encrypted." TODO: This breaks a couple of tests until removal of protected chats is merged.
Tested on some random chat, the SQL query took 1.411202ms (vs 6.692714ms before) in median. Still looks a bit slow, but already better.
iequidoo
force-pushed
the
iequidoo/unbend-calc_sort_timestamp
branch
from
8c77e2a to
295215c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7116
This also improves performance of
calc_sort_timestamp(). See commit messages.