feat: Always watch Inbox if MvboxMove is set (#7187) #7234
+53
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2260156. Some users still want to get messages from all folders as reported by @gerryfrancis.
If `OnlyFetchMvbox` is enabled, `MvboxMove` ("Move automatically to DeltaChat folder") makes no
sense: useful messages from "Spam" are moved anyway to "DeltaChat" (see
`imap::spam_target_folder_cfg()`) and Inbox messages aren't fetched and moved. Then `MvboxMove` can
mean "Move Inbox and all scanned folders' messages to DeltaChat", so if it's enabled, Inbox is
watched too, so the user can configure fetching only from "Inbox", "DeltaChat" and "Spam" which was
unachievable before and helps e.g. for the Gmail case which has many virtual folders and the whole
folder scanning process is really slow (and useless for most users):
#7178 (comment). This may also be useful if the
user has another messenger, e.g. a Delta Chat fork who moves messages to "ZetaChat": this folder
shouldn't be scanned, but Inbox should be. Mvbox is watched anyway, this should just be made clear
to users (if not already).
For existing users accidentally having both options enabled "MvboxMove" is disabled in a migration
to not cause watching Inbox.
Having both options disabled means that we don't separate chat messages from non-chat ones, scanning
all folders is fine in this case.
This is a replacement for 2260156 "feat: Don't fetch messages from unknown folders", but limited to the case with `MvboxMove` enabled. It's enabled by default, so most users still gain from not fetching messages from unknown folders.
iequidoo
force-pushed
the
iequidoo/always-fetch-inbox-on-mvbox_move
branch
from
3d8483d to
851b479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7187
See commit messages. This is an alternative to #7200 made after @gerryfrancis's report that it breaks their use case. Python tests can be fixed up if we decide to merge this.
feat: Enable OnlyFetchMvbox by default (#7190)here is to preserve the default behavior of #7200.I'd vote for this change set, it only adds a couple of LOCs + two migrations. DC Desktop only needs to allow setting both options independently, DC Android already allows this. UI's option descriptions may be adjusted later, these are advanced settings and mostly the descriptions remain correct.