Skip to content

fix: do not set normalized name for existing chats and contacts in a migration#7603

Merged
link2xt merged 1 commit intomainfrom
link2xt/faster-migration-143
Dec 12, 2025
Merged

fix: do not set normalized name for existing chats and contacts in a migration#7603
link2xt merged 1 commit intomainfrom
link2xt/faster-migration-143

Conversation

@link2xt
Copy link
Collaborator

@link2xt link2xt commented Dec 12, 2025

We got a report that application is not responding after update on Android and getting killed before it can start, suspected to be a slow SQL migration:
#7602

This change removes calculation of normalized names for existing chats and contacts added in
#7548
to exclude the possibility of this migration being slow. New chats and contacts will still get normalized names and all chats and contacts will get it when they are renamed.

…migration

We got a report that application is not responding after update
on Android and getting killed before it can start,
suspected to be a slow SQL migration:
<#7602>

This change removes calculation of normalized names for
existing chats and contacts added in
<#7548>
to exclude the possibility of this migration being slow.
New chats and contacts will still get normalized names
and all chats and contacts will get it when they are renamed.
@link2xt link2xt force-pushed the link2xt/faster-migration-143 branch from 117636c to a2c16c6 Compare December 12, 2025 15:33
Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was instant for me, but i don't have thousands of contacts/chats. Maybe 10000 is too much. Anyway, fine to remove this code completely

@link2xt link2xt marked this pull request as ready for review December 12, 2025 15:38
@link2xt
Copy link
Collaborator Author

link2xt commented Dec 12, 2025

It was instant for me, but i don't have thousands of contacts/chats. Maybe 10000 is too much. Anyway, fine to remove this code completely

It could also be that the issue is imap migration, but we don't know because we don't have logs this early (see original issue). And the user has Fairphone 3 that apparently has slower eMMC storage than recent phones with UFS. I also have not found the data on actual throughput etc. of storage, everyone just states the storage size and standard.

@link2xt link2xt merged commit d87d87f into main Dec 12, 2025
30 checks passed
@link2xt link2xt deleted the link2xt/faster-migration-143 branch December 12, 2025 15:44
@link2xt
Copy link
Collaborator Author

link2xt commented Dec 12, 2025

For the record, this did not solve the problem at least entirely, some other migration like maybe 140 still takes a lot of time with large database: #7602 (comment)
But let's keep this merged, it anyway saves some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants