fix: Send bcc-self messages to all own relays (#7656) #7706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This makes |
Simon-Laux
approved these changes
Jan 11, 2026
iequidoo
force-pushed
the
iequidoo/bcc-self-to-all-relays
branch
from
e32b229 to
d3bb93d
Compare
iequidoo
commented
Jan 11, 2026
| transaction.execute( | ||
| "UPDATE config SET value=? WHERE keyname='configured_addr'", | ||
| " | ||
| UPDATE config SET value=? WHERE keyname='configured_addr' AND value!=?1 |
Collaborator
Author
There was a problem hiding this comment.
AND value!=?1 is needed because SQLite counts all updates for which the WHERE condition is true, not just updates that really update rows
link2xt
reviewed
Jan 11, 2026
iequidoo
force-pushed
the
iequidoo/bcc-self-to-all-relays
branch
from
d3bb93d to
453ffe4
Compare
link2xt
approved these changes
Jan 11, 2026
This fixes the bug when a new transport doesn't become primary on the 2nd device because INBOX from the new transport isn't fully fetched. Now the `Transports` sync message is received from the old transport, but as it has updated "From", it updates the primary transport correspondingly. NB: I/O for the new primary transport isn't immediately started however, this needs a separate fix.
This way, if the sync message updates transports, the check for a new primary transport is done against the updated transport list which is more reliable.
Otherwise it's not possible to write tests reliably because sync messages may be executed multiple times if they arrive from different transports. This should fix flaky `test_transport_synchronization`. Also always emit `TransportsModified` if the primary transport is changed by a sync message, even if it doesn't contain `SyncData::Transports`. Also don't decrease `add_timestamp` in `save_transport()` if nothing else changes, this doesn't make sense.
iequidoo
force-pushed
the
iequidoo/bcc-self-to-all-relays
branch
from
453ffe4 to
a845d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug when a new transport doesn't become primary on the 2nd device because INBOX from the new transport isn't fully fetched. Now the
Transportssync message is received from the old transport, but as it has updated "From", it updates the primary transport correspondingly. NB: I/O for the new primary transport isn't immediately started however, this needs a separate fix.There are additional commits, see commit messages. Particularly,
fix: Only emit TransportsModified if transports are really modifiedis needed to fix tests flakiness introduced by the subject change, so not moving it to a separate PR.Close #7656