Make fluent_test an E2E test #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhances the fluentd test that previously required an existing test environment (with a VPC, a bucket, and an EKS cluster) to not depend it. It uses another library `mumoshu/testkit` and some terraform code to provision and reference to necessary AWS and K8s resources within the test. At this point, I verified it to work with the following envvars: - AWS_DEFAULT_REGION - AWS_ACCESS_KEY_ID - AWS_SECRET_ACCESS_KEY - VPC_ID (at least two public subnets needed) The only TODO is that, the test does not clean up the S3 bucket. `testkit` does run `terraform destroy` on test cleanup, but we don't yet clean up objects in the bucket beforehand, which prevents the bucket deletion.
cw-sakamoto
approved these changes
Feb 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the fluentd test that previously required an existing test environment (with a VPC, a bucket, and an EKS cluster) to not depend it.
It uses another library
mumoshu/testkitand some terraform code to provision and reference to necessary AWS and K8s resources within the test.At this point, I verified it to work with the following envvars:
The only TODO is that, the test does not clean up the S3 bucket.
testkitdoes runterraform destroyon test cleanup, but we don't yet clean up objects in the bucket beforehand, which prevents the bucket deletion.