Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ingress TestCheck into an E2e test #32

Merged
merged 2 commits into from
May 14, 2024

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Apr 30, 2024

This modifies the ingress checker in several ways to make the ingress checker's TestCheck an E2E test:

  • Added the checker an ability to send HTTP get request to the specified HTTP endpoint to verify the ingress controller and the ingress resource is working
  • Adds NoHTTPCheck similar to the existing NoDnsCheck to opt-out of doing the HTTP check
  • Fixed the test deployment's container port and service targetPort to use 80 instead of 8080, as the container seems to be listening on 80 instead of the previous value 8080
  • Added ProcessHandle and StartProcess test helpers to automate running and stopping cluster-provider-kind. I'll try to move this to testkit later

@cw-sakamoto
Copy link
Contributor

@mumoshu Thank you for your contribution!

@cw-sakamoto cw-sakamoto merged commit c04e273 into chatwork:main May 14, 2024
@mumoshu mumoshu deleted the ingress-test-e2e branch May 14, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants