#429: Implement GET /subscription_user Endpoint #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t [WIP][Refactor][Tests]
…verly nested response.
|
@Tim-Quattrochi sorry to be so slow to get to this! I am looking at this and your questions now. 😄 |
eleanorreem
reviewed
Aug 28, 2024
eleanorreem
reviewed
Aug 28, 2024
eleanorreem
reviewed
Aug 28, 2024
|
@Tim-Quattrochi this is great! Thanks! Just a couple tiny things and then we are good. Again sorry this took so long! |
Thanks. I left a comment on the nested object dto. I pushed the abstraction of serializing data to utils. |
|
@Tim-Quattrochi your question was a good one and thanks for your input! I can see the issue now that you were coming across. I hadn't realised the limitations of DTOs. That is my bad. Returning a mapped array is grand. I have resolved the conflicts and deleted the extra DTO. THanks again for your input ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#429
What changes did you make?
I created DTOs to define the structure of what will be sent/exchanged.
GetSubscriptionUserDtoGetSubscriptionUsersDtoI created a method in the
SubscriptionUserServicethat returns all the subscriptions by a user id.I created a method in the
SubscriptionUserControllerthat gets the authenticated user from the request. I used thereq['UserEntity]instead ofreq['user']because I seen in other issues that this will be the main way to retrieve the user. I then formatted the response to adhere to the requested structure in the issue.Why did you make the changes?
The application wants to separate the users subscriptions from the
/user/meendpoint, that way the client can request this/api/v1/subscription-user/subscription_useras needed to only retrieve the subscriptions.Did you run tests?
I created and ran 2 unit tests in the existing subscription-user.spec.ts (Passing).