Improve test delays #1013
Open
Improve test delays #1013
+114
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 failed tests on run #546 ↗︎
Details:
Review all test suite changes for PR #1013 ↗︎ |
||||||||||||||||||||
….0 (#962) Bumps [newrelic/deployment-marker-action](https://github.com/newrelic/deployment-marker-action) from 2.2.0 to 2.5.0. - [Release notes](https://github.com/newrelic/deployment-marker-action/releases) - [Changelog](https://github.com/newrelic/deployment-marker-action/blob/main/CHANGELOG.md) - [Commits](newrelic/deployment-marker-action@v2.2.0...v2.5.0) --- updated-dependencies: - dependency-name: newrelic/deployment-marker-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@annarhughes timeouts don't affect run time like cy.wait. I think they are pretty safe and don't actually cause delays. They just tell the app to wait a bit longer than the default wait time which i think is 4 seconds. It mades the tests less flakey. However, it probably allows the tests to run slower than we'd like. I wonder how we could make the tests run faster meaning we can eventually remove the timeouts. There are various solutions in this article. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Quick test to see if test delays can be reduced
Why did you make the changes?
Our tests currently take a long time to complete and we have many waits that may not be necessary. testing the theory that some can be removed or reduced