App router migration root layout #1085
Conversation
|
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
|
@annarhughes I think better to create a app-router-migration branch so I can point all PR to that one, let me know when it is created to edit the PR so it points to app-router-migration |
boodland
force-pushed
the
app-router-migration-root-layout
branch
from
c433cfb
to
d857356
Compare
|
Hey @boodland are you able to create that parent branch yourself, or even use this branch as the base/parent branch? |
Hi @annarhughes, I already tried to use this branch as the parent branch and all the PRs are created in my repo, not visible to Chayn and without Chayn's PR template. I don't think I am able to create a branch in Chayn repo, so please create one so I can point to and carry on with the development. Thanks! |
|
@eleanorreem, @annarhughes I have just changed the base branch, have a look when possible. Thanks |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| children: React.ReactNode; | ||
| }) { | ||
| return ( | ||
| <html lang="en"> |
There was a problem hiding this comment.
What the impact of setting lang="en" on a multi-lingual site? Might be worth making a TODO to address this later?
There was a problem hiding this comment.
Once i18n is added the value will be set to locale. It is good to add a value for a11y reasons the issue is when the selected locale is not English (the default one) as not all the content within the site is translated to all available languages
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
Hi @eleanorreem, doesn't looks like as there isn't any empty folder within app one. It is automatically added when running yarn dev command, try to remove the line and run the command to see if it is also adding it for you, if it is the case, I would say is a reference that app router uses and needs to have in the definitions file
|
@eleanorreem could you merge develop within nex-js-migration when possible in order to have the latest version? Thanks! |
|
done! Thanks @boodland |
Parent PR for the progressive migration of _app.tsx and _document.tsx within the Root Layout
Issue link / number:
#1083
What changes did you make?
Why did you make the changes?
In order to be able to migrate the product from pages router to app router and benefits of all the new features available in the app router
Did you run tests?
Yes
Navigate to http://localhost:3000/public-route-test to check that title, charset and viewport meta tags are added properly