Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap e2e test #1116

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Sitemap e2e test #1116

merged 5 commits into from
Sep 20, 2024

Conversation

boodland
Copy link
Contributor

@boodland boodland commented Sep 2, 2024

Issue link / number:

#1089

What changes did you make?

Fixed sitemap urls
Created sitemap e2e test

Why did you make the changes?

So the page is covered with test and help us to validate it is working when making changes or migrating it to app router

Did you run tests?

Yes

Copy link

vercel bot commented Sep 2, 2024

@boodland is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@boodland boodland mentioned this pull request Sep 2, 2024
pages/sitemap.xml.tsx Outdated Show resolved Hide resolved
@eleanorreem
Copy link
Contributor

Thanks @boodland ! 1 small change!

@boodland
Copy link
Contributor Author

@eleanorreem changes applied!

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:17am

@eleanorreem eleanorreem self-assigned this Sep 20, 2024
@eleanorreem eleanorreem merged commit 7388d98 into chaynHQ:develop Sep 20, 2024
5 of 6 checks passed
Copy link

cypress bot commented Sep 20, 2024

Bloom frontend    Run #732

Run Properties:  status check passed Passed #732  •  git commit 7388d983d1: Sitemap e2e test (#1116)
Project Bloom frontend
Branch Review develop
Run status status check passed Passed #732
Run duration 08m 42s
Commit git commit 7388d983d1: Sitemap e2e test (#1116)
Committer Alberto Arias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 85
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@boodland boodland deleted the sitemap-e2e-test branch September 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants