App router migration google tag manager script #1117
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children PR for the progressive migration of _app.tsx and _document.tsx within the Root Layout
Issue link / number:
#1083
What changes did you make?
Changed script strategy to
afterInteractiveasworkerdoesn't work for app routerhttps://nextjs.org/docs/pages/building-your-application/optimizing/scripts#offloading-scripts-to-a-web-worker-experimental
https://nextjs.org/docs/pages/api-reference/components/script#afterinteractive
Added google tag manager configuration to root layout
Moved Script from _document to _app as recommended in the pages router documentation
https://nextjs.org/docs/pages/building-your-application/optimizing/scripts#application-scripts
https://nextjs.org/docs/pages/api-reference/components/script#afterinteractive
Added comment about new approach not being used due to how events are pushed to the dataLayer
Why did you make the changes?
In order to be able to have google tag manager within app router
Did you run tests?
Yes
Navigate to http://localhost:3000/ to check that the head gtag and body scripts are added properly
Navigate to http://localhost:3000/public-route-test to check that the head gtag and body scripts are added properly