Feature/account page

[anmol-fzr]

Issue

Issue Number: 865

Issue Link: #865

What changes did you make?

Added Account Page with UI + Functionality + Translations. Delete Account button is intentionally left disabled reason being API to delete account by user isn't ready

Why did you make the changes?

Changes are made to fix the issue

Did you run tests?

Added a test named user-profile-update that ran successfully

[vercel]

@anmol-fzr is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

[eleanorreem]

Thanks so much for this, loads of work 🎉

I know that this PR is WIP so apologies for all the comments. I had a look through the code in combination with the current functionality that we had in the backend. These are my comments:

• The backend for updating an email isn't implemented so for now it is best just to have the Profile details form as per the designs (i.e. add the link in the issue to the getting in touch text and remove the button). If you would like to contribute this work at a later date, I can tag you in the issue when it comes up and you can simply implement the work you have already done. Let me know if that works for you!
• The backend for deleting an account isn't ready yet and is going to be a bit complicated. For the sake of getting this merged soon, I would remove the Account Actions section for the PR and save it for the next issue that I will write up in the near future.
• The email subscription form works well. I am happy with it. We will need to have some error / success feedback for the user. Please see the bloom-frontend/components/forms/CreateAccessCodeForm.tsx for some input on how you might implement that. For now the success can just be "Your email subscription preferences have been updated"
• There are some console logs and commented out code that will need tidying up.
• As you have included more functionality in this PR than in the original ticket, you would need to add more functionality to the cypress test. In the new cypress test, you will need to check the profile details and that updating your subscription preferences works.
• The header h1 and description isn't quite aligned with the middle of the image. You might need to add a marginTop: auto and a marginBottom: auto the top and bottom of the div that contains the header and description. I hope that makes sense.
• There are errors when I run yarn build and yarn lint so it would be great if you could sort the single quotes.
• I don't know if you experience this but the page flashes on load which doesn't seem to happen to other pages.I think its because some code has been copied over from the disable service emails page that shouldn't be there. The whole use effect can go.
• When you have made all the changes, it would be awesome if you could soft reset the branch and redo the commits, excluding the features we aren't going to include in this PR otherwise it might get confusing that we are adding features and then taking them away.

Sorry for the long list of comments! What you have done so far is great. Thank you for all your work. Please do keep the work that isn't going to be included in this PR and we can use it in the very near future.

[eleanorreem]

I think I see where you have copied this from. This shouldn't be there, that functionality is only for the disable-service-email.tsx page.

[eleanorreem]

Thanks for your changes! They look great. There were a few more changes that were on PR. It would be great if they could be resolved. These are the ones outstanding:

• removing account actions from the card
• success/ error handling for saving profile information
• The cypress test doesn't test whether the correct email is displaying, it just tests that the box is disabled. Ideally you would be checking against the email address and also checking that when you update your subscription preferences, it works.
• Header alignment

[eleanorreem]

@anmol-fzr, thanks for all your work so far! Just checking in here to make sure you have everything you need to finish off this ticket. Absolutely no pressure, it would just be great to get this contribution merged!

[anmol-fzr]

@eleanorreem , I made the changes to the code suggest in this review please check.

[eleanorreem]

Hi thank you for your quick reply and all the work so far! There were a few more things that I commented on your pull request - take a look through the pull request files. There are some unresolved comments that need to be addressed before I can merge.

[anmol-fzr]

@eleanorreem I made change told last time about removing account action card to header alignment. It would be great if you review the code for merge or we resolve anything that needs to be done for this PR

[eleanorreem]

Hiya @anmol-fzr, Thanks for your response 😄

There are these open comments on your PR. Let me know if you have any questions. I linked to the most of the comments here.

• Can you delete this file
• Can you add an await to ensure this function is async and ensure that there is a success and failure scenrio. I have signposted in the comment where to look for examples.
• You've left commented out code which would be great to be removed.
  
• I had a question about some changes
• Please note the cypress test doesn’t cover the functionality of updating your subscription preferences, specified in the comments above.

Please check through the open comments and make sure they are all resolved.

Thanks in advance for everything !

[anmol-fzr]

@eleanorreem i made suggested changes, please check

[anmol-fzr]

hope we can merge this now