fix(bot): handling of duplicate check suites #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a user created duplicate check suites with the same check run name, Kodiak would consider all of the check suites, not just the most recent one. So if the check suite had failed previously, but the latest check suite passed, Kodiak would incorrectly mark the PR as blocked for merging. Now Kodiak only considers the most recent check run name.
sbdchd
reviewed
Jul 11, 2021
bot/kodiak/evaluation.py
Outdated
Comment on lines
267
to
270
| check_run_map = dict() | ||
| for check_run in check_runs: | ||
| check_run_map[check_run.name] = check_run | ||
| return list(check_run_map.values()) |
There was a problem hiding this comment.
Suggested change
| check_run_map = dict() | |
| for check_run in check_runs: | |
| check_run_map[check_run.name] = check_run | |
| return list(check_run_map.values()) | |
| check_run_map = { | |
| check_run.name: check_run | |
| for check_run in check_runs | |
| } | |
| return check_run_map.values() |
sbdchd
reviewed
Jul 11, 2021
bot/kodiak/evaluation.py
Outdated
| @@ -260,6 +263,13 @@ def review_status(reviews: List[PRReview]) -> PRReviewState: | |||
| return status | |||
|
|
|||
|
|
|||
| def deduplicate_check_runs(check_runs: Iterable[CheckRun]) -> List[CheckRun]: | |||
There was a problem hiding this comment.
Suggested change
| def deduplicate_check_runs(check_runs: Iterable[CheckRun]) -> List[CheckRun]: | |
| def deduplicate_check_runs(check_runs: Iterable[CheckRun]) -> Iterable[CheckRun]: |
sbdchd
reviewed
Jul 11, 2021
| name="Pre-merge checks", conclusion=CheckConclusionState.FAILURE | ||
| ), | ||
| create_check_run( | ||
| name="Pre-merge checks", conclusion=CheckConclusionState.SUCCESS |
There was a problem hiding this comment.
does the GitHub API order the results with the most recent ones last?
There was a problem hiding this comment.
I opened a support ticket about that but my assumption here is yes
sbdchd
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a user created duplicate check suites with the same check run name, Kodiak would consider all of the check suites, not just the most recent one. So if the check suite had failed previously, but the latest check suite passed, Kodiak would incorrectly mark the PR as blocked for merging.
Now Kodiak only considers the most recent check run name.