Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove che-on-start extension #133

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Remove che-on-start extension #133

merged 2 commits into from
Oct 20, 2022

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Oct 19, 2022

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Removes the che-on-start extension as it becomes redundant after merging #131.
The second part of the extension (opening a terminal on VS Code start) we decided to remove as it doesn't add much value to the user, but makes loading IDE visually slower.

What issues does this PR fix?

How to test this PR?

  1. Start a new DevWorkspace with the following test project https://github.com/azatsarynnyy/java-spring-petclinic/tree/onstart.
  2. Check that a new terminal isn't opened automatically after starting VS Code.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy changed the title [WIP] Remove che-on-start extension Remove che-on-start extension Oct 19, 2022
@azatsarynnyy azatsarynnyy marked this pull request as ready for review October 19, 2022 17:59
@azatsarynnyy azatsarynnyy enabled auto-merge (squash) October 19, 2022 17:59
@azatsarynnyy azatsarynnyy merged commit e1eb6a5 into main Oct 20, 2022
@che-bot che-bot added this to the 7.56 milestone Oct 20, 2022
@azatsarynnyy azatsarynnyy deleted the remove-ext branch October 20, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants