Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Filter out the editor-provided commands #192

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: Filter out the editor-provided commands #192

merged 1 commit into from
Mar 24, 2023

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Mar 24, 2023 •
edited
Loading

What does this PR do?

Filters out the editor-provided Devfile commands as they are not expected to be run by the user.

What issues does this PR fix?

Closes eclipse-che/che#22098

How to test this PR?

  1. Start a new workspace from the test project https://github.com/azatsarynnyy/java-spring-petclinic/tree/hide-editor-exec-cmds. Its .che/che-editor.yaml contains the init-che-code-command exec command.
  2. Verify that there is no editor-specific command among the devfile-type Tasks.

@azatsarynnyy
fix: Filter out the editor-provided commands
9684994 
Filter out the editor-provided Devfile commands as they are not expected to be run by the user.
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@azatsarynnyy azatsarynnyy mentioned this pull request Mar 24, 2023
Closed
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-192-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-192-dev-amd64

@azatsarynnyy azatsarynnyy marked this pull request as ready for review March 24, 2023 10:22
@azatsarynnyy azatsarynnyy merged commit 76441cf into main Mar 24, 2023
@azatsarynnyy azatsarynnyy deleted the filter-editor-commands branch March 24, 2023 11:14
@azatsarynnyy azatsarynnyy mentioned this pull request Mar 28, 2023
Merged
@RomanNikitenko RomanNikitenko mentioned this pull request Aug 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk left review comments

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't translate the editor-provided Devfile commands to VS Code Tasks
3 participants
@azatsarynnyy @RomanNikitenko @amisevsk