New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the direct dependency to `node-gyp` since it's bundled with `npm` #403

Merged

azatsarynnyy merged 1 commit into main from no_node-gyp

Sep 16, 2024

Member

azatsarynnyy commented Aug 21, 2024 •

edited

Loading

What does this PR do?

We used to directly depend on node-gyp because it was removed from npm in npm/cli#6554.
Since node-gyp is part of npm again (see npm/cli#6932), there's no need to keep having a direct dependency and maintaining the version up to date.

More technical details: npm/cli#6554 (comment)

What issues does this PR fix?

related to redhat-developer/devspaces-images#627

How to test this PR?

See the passed PR status checks.

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

github-actions bot commented Aug 21, 2024 •

edited

Loading

Click here to review and test in web IDE:

github-actions bot commented Aug 21, 2024

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-403-dev-amd64

2 similar comments

github-actions bot commented Aug 22, 2024

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-403-dev-amd64

github-actions bot commented Aug 22, 2024

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-403-dev-amd64


          Remove node-gyp dependency

f607559

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy force-pushed the no_node-gyp branch from 1618b36 to f607559 Compare

September 6, 2024 10:01

github-actions bot commented Sep 6, 2024

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-403-dev-amd64

1 similar comment

github-actions bot commented Sep 6, 2024

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-403-dev-amd64

azatsarynnyy changed the title ~~[WIP] node-gyp~~ Avoid the direct dependency to node-gyp since it's bundled with npm

azatsarynnyy marked this pull request as ready for review

September 6, 2024 12:03

azatsarynnyy requested review from RomanNikitenko and vitaliy-guliy as code owners

September 6, 2024 12:03

RomanNikitenko approved these changes

View reviewed changes

azatsarynnyy merged commit 5a3639e into main

7 checks passed

azatsarynnyy deleted the no_node-gyp branch

September 16, 2024 11:36

devstudio-release commented Sep 16, 2024

Build 3.17 :: code_3.x/1472: Console, Changes, Git Data

devstudio-release commented Sep 16, 2024

Build 3.17 :: code_3.x/1472:

Upstream sync done; No sync or Brew build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet