Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cursor behavior in the terminal #55

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix the cursor behavior in the terminal #55

merged 1 commit into from
Jun 16, 2022

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Jun 15, 2022

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

The PR fixes the cursor behavior in the embedded terminal.

fixes eclipse-che/che#21473

How to test

  1. Spin up a DevWorkspace using the following link:
    che-host#https://github.com/azatsarynnyy/java-spring-petclinic/tree/devfilev2.
  2. In the terminal, try to type more than one row of text.

The cursor should move to a new line.

Before:
1

After:

2

@github-actions

This comment was marked as outdated.

2 similar comments
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy changed the title [WIP] Check terminal [WIP] Fix the cursor behavior in the terminal Jun 16, 2022
@azatsarynnyy azatsarynnyy changed the title [WIP] Fix the cursor behavior in the terminal Fix the cursor behavior in the terminal Jun 16, 2022
@azatsarynnyy azatsarynnyy marked this pull request as ready for review June 16, 2022 17:24
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-55-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-55-dev-amd64

@azatsarynnyy azatsarynnyy merged commit 6c9a185 into main Jun 16, 2022
@azatsarynnyy azatsarynnyy deleted the term branch June 16, 2022 18:18
@che-bot che-bot added this to the 7.48 milestone Jun 16, 2022
@azatsarynnyy azatsarynnyy modified the milestones: 7.48, 7.50 Jun 17, 2022
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-55-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-55-dev-amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Visual Studio Code as a Che editor, the lines in the terminal are truncated and overlap
3 participants