Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Add test coverage #75

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Add test coverage #75

merged 3 commits into from
Nov 19, 2020

Conversation

olexii4
Copy link
Collaborator

@olexii4 olexii4 commented Nov 18, 2020

What does this PR do?

These changes bring generation a human-readable HTML coverage report with good navigation per directories. It will help to clarify the current situation with test-coverage.

If test coverage is less than minimal it will reject git-push to upstream.

Which issue does this PR related to?

eclipse-che/che#18391 (0 stage)

Screenshot from 2020-11-18 22-18-04
Screenshot from 2020-11-18 22-18-32

Signed-off-by: Oleksii Orel oorel@redhat.com

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@sleshchenko
Copy link
Collaborator

If test coverage is less than minimal it will reject git-push to upstream.

Is it only about upstream or any remote, master or any branch? I think that's OK to push changes without tests in your branch to collaborate together or let someone review.

@akurinnoy
Copy link
Collaborator

@sleshchenko I've added the fix for test coverage check. Now it can be started manually by user yarn test:coverage and GH action runs it for each commit in pull request as well.

@olexii4 olexii4 merged commit cafe707 into master Nov 19, 2020
@olexii4 olexii4 deleted the CHE-18391 branch November 19, 2020 11:12
akurinnoy added a commit to akurinnoy/che-dashboard-next that referenced this pull request Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants