-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove travis scripts and add github actions for release purpose #1033
Conversation
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
I'm testing this changes agains my fork and releases looks identical: https://github.com/flacatus/chectl |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
… enxt Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I didn't run this. Deferring to others for final say. +0.1
@nickboldt https://github.com/flacatus/chectl/releases |
.github/workflows/draft-release.yml
Outdated
run: | | ||
# since we're using Flavius' token below to generate PRs, should also make tags/branches/commits by same owner | ||
# see https://github.com/che-incubator/chectl/settings/secrets/actions for the token used | ||
git config --global user.name "Flavius Lacatusu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be author that perform the release ?
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
870a86e
to
6d1031e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, flacatus, nickboldt, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
Remove travis scripts and add github actions to release stable and next versions of chectl.
Refference issue:eclipse-che/che#18260
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.