Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove travis scripts and add github actions for release purpose #1033

Merged
merged 10 commits into from
Dec 15, 2020

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Dec 14, 2020

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

Remove travis scripts and add github actions to release stable and next versions of chectl.

Refference issue:eclipse-che/che#18260

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

flacatus commented Dec 14, 2020

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
… enxt

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@nickboldt nickboldt self-requested a review December 14, 2020 20:59
Copy link
Collaborator

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I didn't run this. Deferring to others for final say. +0.1

@flacatus
Copy link
Collaborator Author

run: |
# since we're using Flavius' token below to generate PRs, should also make tags/branches/commits by same owner
# see https://github.com/che-incubator/chectl/settings/secrets/actions for the token used
git config --global user.name "Flavius Lacatusu"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be author that perform the release ?

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus flacatus changed the title feat: Remove travis scripts and add github actions feat: Remove travis scripts and add github actions for release purpose Dec 14, 2020
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, flacatus, nickboldt, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants