Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MicroK8s as a platform option #146

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Conversation

thokra
Copy link
Contributor

@thokra thokra commented Jun 7, 2019

This adds support for MicroK8s as a possible installation platform. It's mostly just a copy of the minikube setup, with a few extra MicroK8s details.

It will enable the ingress addon if it is disabled, but it will just error out if the storage addon is disabled or if MicroK8s isn't running.
This is mostly because sudo is required, and I'm not familiar enough with JS/TS to get piping of stdout/stdin to work.

Tested it successfully with microk8s v1.14.2 and helm

@benoitf
Copy link
Collaborator

benoitf commented Jun 17, 2019

somehow I missed that contribution, great

@thokra: AFAIK microk8s is relying on microk8s.kubectl command instead of kubectl but here we check and use kubectl ?

@l0rd
Copy link
Collaborator

l0rd commented Jun 19, 2019

I have tested this PR and could run microk8s. But to do so I have been blocked a few times:

  • 1st try failed because kubectl was not found but microk8s.kubectl was installed
    image
    I fixed that with sudo snap alias microk8s.kubectl kubectl
  • 2nd try failed at start microk8s step. It looks like it didn't found out that microk8s was running (indeed it was)
    image
    running chectl a third time fixed this problem
  • 3rd try failed at Enable microk8s addon storage step. The addon was not installed initially, chectl installed it and checked again if it was enabled immediately after. But this addon takes a few seconds to be enabled and chectl fails.
    image
    waiting 30s and running chectl again fixed the problem
  • 4th try failed at Verify if Helm is installed step. That's not related to this PR at all but I wanted to track it.
    image
    running sudo snap install helm --classic fixed the problem
  • 5th try was successful. Hurray!!

Am I +1 to merge this PR as it is (because it adds value and doesn't do any harm) and fix the issues with other PRs.

@thokra would you be able to resolve the conflicts so that we can proceed and merge?

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited a past comment as it was not sent before
👍

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if microk8s.kubectl command is used instead of kubectl but it can be addressed later

@l0rd l0rd merged commit 6c96c58 into che-incubator:master Jul 1, 2019
@l0rd l0rd mentioned this pull request Jul 1, 2019
3 tasks
@l0rd
Copy link
Collaborator

l0rd commented Jul 1, 2019

Created #196 to improve microk8s support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants