Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support OLM all namespaces next channel. #1751

Merged
merged 11 commits into from
Oct 19, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Oct 8, 2021

What does this PR do?

Support OLM all namespaces next channel.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20455

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
…nd delete.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1751 (dbb4643) into main (cccfc9a) will increase coverage by 0.15%.
The diff coverage is 20.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
+ Coverage   10.77%   10.93%   +0.15%     
==========================================
  Files          64       64              
  Lines        7156     7180      +24     
  Branches     1212     1214       +2     
==========================================
+ Hits          771      785      +14     
- Misses       6385     6395      +10     
Impacted Files Coverage Δ
src/commands/server/deploy.ts 0.00% <0.00%> (ø)
src/commands/server/restore.ts 0.00% <0.00%> (ø)
src/tasks/installers/olm.ts 0.00% <0.00%> (ø)
src/api/kube.ts 5.75% <50.00%> (ø)
src/api/context.ts 72.41% <100.00%> (+10.41%) ⬆️
src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccfc9a...dbb4643. Read the comment docs.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

src/api/context.ts Show resolved Hide resolved
src/api/context.ts Show resolved Hide resolved
…ion devworkspace operator.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 18, 2021
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title Support OLM all namespaces next channel. feat: Support OLM all namespaces next channel. Oct 19, 2021
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@AndrienkoAleksandr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-chectl-e2e-olm-installer e6de68d link true /test v8-chectl-e2e-olm-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AndrienkoAleksandr AndrienkoAleksandr merged commit 41ce6f4 into main Oct 19, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the supportNextAllNamespacesOLMChannel branch October 19, 2021 14:28
@che-bot che-bot added this to the 7.38 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants