Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn user if DevWorkspace is enabled on k8s #1786

Merged
merged 1 commit into from
Oct 21, 2021
Merged

chore: warn user if DevWorkspace is enabled on k8s #1786

merged 1 commit into from
Oct 21, 2021

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Oct 21, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Warn user if DevWorkspace is enabled on k8s

Screenshot/screencast of this PR

DevWorkspace is experimental feature. It requires direct access to the underlying infrastructure REST API.
This results in huge privilege escalation. Do you want to proceed? [y/n]:

What issues does this PR fix or reference?

eclipse-che/che#20620

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun assigned tolusha and unassigned mmorhun Oct 21, 2021
@tolusha tolusha merged commit 4972fc1 into main Oct 21, 2021
@tolusha tolusha deleted the 20620 branch October 21, 2021 12:01
@che-bot che-bot added this to the 7.39 milestone Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants