Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use name as username claim and add more users to dex on minikube #1820

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Nov 11, 2021

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

  • use name as username claim when using dex with minikube. This ends up as user name in Kubernetes to bind roles.
  • add more users for testing (user1-5 with password password)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

part of eclipse-che/che#20635

How to test this PR?

It's not easy to test it. You need to deploy some app that will be configured and utilize OIDC settings. For example app from here https://github.com/che-incubator/che-auth-playground/tree/master/minikube_dex. You should be able to login with added users and control RBAC with username instead of an email.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Michal Vala <mvala@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sparkoo
Copy link
Member Author

sparkoo commented Nov 12, 2021

/retest

@tolusha
Copy link
Collaborator

tolusha commented Nov 12, 2021

All OCP tests are failing now due to infrastructure issue. pls ignore

@sparkoo
Copy link
Member Author

sparkoo commented Nov 12, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2021

@sparkoo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-chectl-e2e-operator-installer d0ca00f link true /test v7-chectl-e2e-operator-installer
ci/prow/v7-chectl-e2e-olm-installer d0ca00f link true /test v7-chectl-e2e-olm-installer
ci/prow/v8-chectl-e2e-olm-installer d0ca00f link true /test v8-chectl-e2e-olm-installer
ci/prow/v8-chectl-e2e-operator-installer d0ca00f link true /test v8-chectl-e2e-operator-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sparkoo
Copy link
Member Author

sparkoo commented Nov 12, 2021

/retest

@sparkoo sparkoo merged commit c5da379 into che-incubator:main Nov 12, 2021
@sparkoo sparkoo deleted the gh20635-dexUsernameClaim branch November 12, 2021 13:33
@che-bot che-bot added this to the 7.40 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants