feat: use name as username claim and add more users to dex on minikube #1820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
name
as username claim when using dex with minikube. This ends up as user name in Kubernetes to bind roles.password
password)Screenshot/screencast of this PR
What issues does this PR fix or reference?
part of eclipse-che/che#20635
How to test this PR?
It's not easy to test it. You need to deploy some app that will be configured and utilize OIDC settings. For example app from here https://github.com/che-incubator/che-auth-playground/tree/master/minikube_dex. You should be able to login with added users and control RBAC with username instead of an email.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.