Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Don't allow 'devworkspace' engine update for previous installations with 'che-server' engine. #1873

Merged
merged 1 commit into from
Dec 7, 2021
Merged

feat: Don't allow 'devworkspace' engine update for previous installations with 'che-server' engine. #1873

merged 1 commit into from
Dec 7, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 6, 2021 •
edited by tolusha
Loading

What does this PR do?

Don't allow 'devworkspace' engine update for previous installations with 'che-server' engine.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20865

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@tolusha tolusha mentioned this pull request Dec 7, 2021
Closed
28 tasks
@AndrienkoAleksandr @tolusha
fix: Don't allow 'devworkspace' engine update for previous installati…
19b37a4 
…ons with 'che-server' engine.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Dec 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-chectl-e2e-olm-installer 19b37a4 link true /test v7-chectl-e2e-olm-installer
ci/prow/v7-chectl-e2e-operator-installer 19b37a4 link true /test v7-chectl-e2e-operator-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@AndrienkoAleksandr AndrienkoAleksandr merged commit 33ff4d2 into main Dec 7, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the CHE-20865 branch December 7, 2021 10:48
@che-bot che-bot added this to the 7.41 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@flacatus flacatus Awaiting requested review from flacatus

@mmorhun mmorhun Awaiting requested review from mmorhun

Assignees

@tolusha tolusha

Labels
lgtm
Projects
None yet
Milestone
7.41
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrienkoAleksandr @tolusha @che-bot