Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for overriding plugin registry url and devfile registry url at the server start. #189

Merged
merged 6 commits into from
Jul 17, 2019

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jun 24, 2019

As the most controversial thing in this PR I've changed the dependency on eclipse-che (from which the helm charts are extracted at build time) to the master branch instead of a fixed (and old) commit.

While this makes the build not reproducible, it also makes us always use the latest helm chart instead of its outdated snapshot.

This implements #114

@metlos metlos requested review from l0rd, benoitf and sleshchenko June 25, 2019 08:09
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@l0rd
Copy link
Collaborator

l0rd commented Jul 15, 2019

@metlos what should we do with this PR? I am +1 to merge if you can rebase it

@metlos
Copy link
Contributor Author

metlos commented Jul 17, 2019

I've successfully rebased this and also updated the operator to support configuring the devfile registry url (which has already been merged). Let me retest this once more before merging.

@l0rd
Copy link
Collaborator

l0rd commented Jul 17, 2019

@metlos if you squash your commits take into account that we are using https://www.conventionalcommits.org/en/v1.0.0-beta.2/ (c.f. the Semantic Pull Request check)

@metlos metlos changed the title Add support for overriding plugin registry and devfile registry at server start. feat: Add support for overriding plugin registry and devfile registry at server start. Jul 17, 2019
@metlos metlos changed the title feat: Add support for overriding plugin registry and devfile registry at server start. feat: Add support for overriding plugin registry url and devfile registry url at the server start. Jul 17, 2019
@metlos metlos merged commit 2b3af05 into che-incubator:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants