-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for overriding plugin registry url and devfile registry url at the server start. #189
Conversation
@metlos what should we do with this PR? I am +1 to merge if you can rebase it |
I've successfully rebased this and also updated the operator to support configuring the devfile registry url (which has already been merged). Let me retest this once more before merging. |
@metlos if you squash your commits take into account that we are using https://www.conventionalcommits.org/en/v1.0.0-beta.2/ (c.f. the Semantic Pull Request check) |
As the most controversial thing in this PR I've changed the dependency on eclipse-che (from which the helm charts are extracted at build time) to the master branch instead of a fixed (and old) commit.
While this makes the build not reproducible, it also makes us always use the latest helm chart instead of its outdated snapshot.
This implements #114