Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate correct certificate for dex #2009

Merged
merged 4 commits into from
Jun 30, 2022
Merged

fix: Generate correct certificate for dex #2009

merged 4 commits into from
Jun 30, 2022

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Feb 4, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

fix: Generate certificate for dex

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21074

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #2009 (42e4780) into main (ff2ca6b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #2009      +/-   ##
========================================
- Coverage   9.93%   9.93%   -0.01%     
========================================
  Files         44      44              
  Lines       4790    4792       +2     
  Branches     763     767       +4     
========================================
  Hits         476     476              
- Misses      4314    4316       +2     
Impacted Files Coverage Δ
src/tasks/component-installers/cert-manager.ts 0.00% <0.00%> (ø)
src/tasks/component-installers/dex.ts 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title chore: Update cert-manager fix: Generate certificate for dex Jun 29, 2022
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review June 30, 2022 10:51
@tolusha tolusha requested a review from flacatus as a code owner June 30, 2022 10:51
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title fix: Generate certificate for dex fix: Generate correct certificate for dex Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-chectl-e2e-olm-installer ec8ab19 link true /test v8-chectl-e2e-olm-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 921d8ad into main Jun 30, 2022
@tolusha tolusha deleted the 21074 branch June 30, 2022 12:11
@che-bot che-bot added this to the 7.50 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants