Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detecting arch for Darwin os #2601

Merged
merged 5 commits into from
Mar 15, 2023
Merged

fix: detecting arch for Darwin os #2601

merged 5 commits into from
Mar 15, 2023

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Mar 15, 2023

tolusha added 2 commits March 15, 2023 10:34
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix of the script looks good but we still need a stable-darwin-arm64 etc pages to redirect the user to the right download file

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Mar 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

New changes are detected. LGTM label has been removed.

tolusha added 2 commits March 15, 2023 10:42
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit dcbdb77 into gh-pages Mar 15, 2023
@tolusha tolusha deleted the 22058 branch March 15, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants