Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated oc-test-happy-path.sh according to new test scripts in "Che" project #2613

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

nallikaea
Copy link
Contributor

What does this PR do?

According to task #22043 test scripts were updated, necessary changes added to this repository.
PR: #22052

The old npm script "test-empty-workspace-devworkspace-happy-path-code" runs one test spec file - "EmptyWorkspace.spec.ts" from the test directory and uses hard-coded mocha config.
It was replaced with "test-all-devfiles" which uses new dynamic mocha config and will run the same file if variable "USERSTORY=EmptyWorkspace" or all test specs in the test directory if variable not set.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

How to test this PR?

Run happy-pass PR check.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…project

Signed-off-by: mdolhalo <mdolhalo@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nallikaea

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

Hi @nallikaea. Thanks for your PR.

I'm waiting for a che-incubator member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tolusha tolusha merged commit 3b2c167 into che-incubator:main Mar 23, 2023
@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/737: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/737: SUCCESS

3.5.1 GA; published to spmm-util

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/738: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/738: SUCCESS

3.5.1 GA; published to spmm-util

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/740: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/740: SUCCESS

3.5.1 GA; published to spmm-util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants