fix: do not fetch service account if it's unneeded #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is made as a result of the following discussion #257 (comment)
Do not fetch the service account if it's unneeded. See attachments:
before:
After:
minishift-addon
operator
It also improves error message when the current context is not set:
before
now
I did not check it on an installation where
healthz
endpoint requires token since I do not know when to find it or how to set up, like even secure OSIO installation havehealthz
as public https://console.starter-us-east-2.openshift.com/healthzIt's like an unplanned quick fix, and some things can be done not in the best way. So, I'm open to proposals related to refactoring or messages.
What issues does this PR fix or reference?
Fixes eclipse-che/che#14534
It partially fixes(there are still may be places that should be addressed) eclipse-che/che#14665
How to test it?
Here are built chectl(based on the master 25.10.2019) that can be used for testing:
https://dropmefiles.com/lVXSh <- Click more to select only package specific to your OS