fix(helm): don't set workspace namespace for helm installer #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
requested review from
azatsarynnyy,
benoitf,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
|
@sparkoo |
|
@tolusha yes. It uses value from helm charts https://github.com/eclipse/che/blob/master/deploy/kubernetes/helm/che/values.yaml#L67 |
tolusha
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
Don't set namespace for workspaces when using helm installer. Helm charts already has reasonable default, which should be used and chectl should not interfere with it. Setting workspaces namespace can be implemented as new chectl parameter, but it's not in scope of this task.
What issues does this PR fix or reference?
eclipse-che/che#15440