feat: Add a chectl preflight check step that verifies that the platform version is supported #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
tolusha
changed the title
mmorhun
reviewed
Feb 10, 2020
src/api/version.ts
Outdated
| return new Error(`The minimal supported version of ${component} is '${minimalVersion} but found '${actualVersion}'. To bypass version check use '--skip-version-check' flag.`) | ||
| } | ||
|
|
||
| private static async getVersionWithOC(versionPrefix: string): Promise<string | undefined> { |
There was a problem hiding this comment.
I think it's not versionPrefix (look at removePrefix), it is more like componentLabel or so.
mmorhun
approved these changes
Feb 10, 2020
AndrienkoAleksandr
approved these changes
Feb 12, 2020
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add minimal versions check for
What issues does this PR fix or reference?
eclipse-che/che#15680