-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use TLS secrets autogeneration mechanism in chectl #679
Conversation
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
✔ Retrieving Eclipse Che server URL... https://che-che.192.168.99.100.nip.io ✔ Eclipse Che status check ✔ Retrieving Che self-signed CA certificate... is exported to /home/tolusha/cheCA.crt ✔ Show important messages ✔ ❗[MANUAL ACTION REQUIRED] Please add Che self-signed CA certificate into your browser: /home/tolusha/cheCA.crt. Documentaton how to add a CA certificate into a browser: https://www.eclipse.org/che/docs/che-7/installing-che-in-tls-mode-with-self-signed-certificates/#using-che-with-tls_installing-che-in-tls-mode-with-self-signed-certificates Command server:start has completed successfully. nice!!! |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun: I have checked Che nightly/PR jobs - they are ready to these changes. |
For the record, setting operator as the default changes nothing in crwctl where that's already the default, and where |
@dmytro-ndp |
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Makes usable the work done in eclipse-che/che#16546.
So now, a user may just run:
At the end of the command execution log will be a message with path to self-signed certificate which should be imported into user's browser and link to the docs how to do it.
Despite the work done toward TLS direction, it is still possible (but deprecated) to use no-tls mode. As usual, create
patch.yaml
with following content:and then pass
--che-operator-cr-patch-yaml=/path/to/pathc.yaml
tochectl
.In case of using Openshift like infrastuctures with self-signed certiicate, where the certificate is embedded into cluster,
chectl
will retrieve it as was described above.This PR sets
operator
installer as default one.What issues does this PR fix or reference?
eclipse-che/che#16052
What was tested
I've tested Che deployment process and a workspace start:
Minikube
:operator
installerhelm
installeroperator
installer in no-tls modeCRC
:operator
installerolm
installer