-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate 'self-signed-cert' flag and implement autodetection for it #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
changed the title
Deprecate and make autodetection for 'self-signed-cert' flag.
feat: Deprecate 'self-signed-cert' flag and implement autodetection for it
May 29, 2020
56 tasks
You have unused imports. |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
tolusha
reviewed
Jun 1, 2020
tolusha
reviewed
Jun 1, 2020
tolusha
approved these changes
Jun 1, 2020
Don't forget |
34 tasks
AndrienkoAleksandr
approved these changes
Jun 1, 2020
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
From e2e tests log:
Seems the problem is with CI node availability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Deprecates
self-signed-cert
option ofserver:start
command.In case of Operator installer this is handled on operator side, see eclipse-che/che-operator#285
In case of Helm installer, chectl checks whether
self-signed-certificate
secret exists and based on that makes conclusion if self-signed certificate is used and put the value into Helm chart.What issues does this PR fix or reference?
Issue: eclipse-che/che#16764
Depends on: eclipse-che/che#17044 and eclipse-che/che-operator#285
Tests
Tested on: