Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate 'self-signed-cert' flag and implement autodetection for it #734

Merged
merged 5 commits into from
Jun 16, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented May 29, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Deprecates self-signed-cert option of server:start command.
In case of Operator installer this is handled on operator side, see eclipse-che/che-operator#285
In case of Helm installer, chectl checks whether self-signed-certificate secret exists and based on that makes conclusion if self-signed certificate is used and put the value into Helm chart.

What issues does this PR fix or reference?

Issue: eclipse-che/che#16764
Depends on: eclipse-che/che#17044 and eclipse-che/che-operator#285

Tests

Tested on:

  • Minikube (Operator and Helm installers)
  • CRC (Operator installer)
  • Openshift (Operator installer with oAuth)
  • Openshift (OLM installer)

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun requested a review from l0rd as a code owner May 29, 2020 09:45
@mmorhun mmorhun self-assigned this May 29, 2020
@mmorhun mmorhun changed the title Deprecate and make autodetection for 'self-signed-cert' flag. feat: Deprecate 'self-signed-cert' flag and implement autodetection for it May 29, 2020
@AndrienkoAleksandr
Copy link
Contributor

You have unused imports.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@tolusha
Copy link
Collaborator

tolusha commented Jun 1, 2020

Don't forget yarn pack

@tolusha tolusha mentioned this pull request Jun 1, 2020
34 tasks
mmorhun added 2 commits June 4, 2020 17:50
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
Copy link
Contributor Author

mmorhun commented Jun 16, 2020

From e2e tests log:

++ cico node get -f value -c ip_address -c comment
The requested operation failed as no inventory is available.
+ cico_output=
+ '[' 1 -eq 0 ']'
+ '[' 16 -gt 15 ']'
+ echo 'giving up on '\''cico node get'\'''
giving up on 'cico node get'
+ exit 1
Build step 'Execute shell' marked build as failure

Seems the problem is with CI node availability.
Merging this PR as it is should be merged together with eclipse-che/che#17044, but current PR check requires eclipse-che/che#17044 to be merged. To avoid broken things merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants