-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't remove CRD if another deployments found #828
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
src/tasks/installers/operator.ts
Outdated
task: async (_ctx: any, task: any) => { | ||
const checlusters = await kh.getAllCheCluster() | ||
if (checlusters.length > 0) { | ||
task.title = await `${task.title}...Another Eclipse Che deployment found.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: ${task.title} ... Skip: another Eclipse Che deployment found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Deletes CRD only if there no another checluster CR
What issues does this PR fix or reference?
eclipse-che/che#16000