Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt chectl to new plugin notation #89

Merged
merged 2 commits into from
May 3, 2019
Merged

Adapt chectl to new plugin notation #89

merged 2 commits into from
May 3, 2019

Conversation

garagatyi
Copy link

Do not merge before eclipse-che/che#13204 gets merged

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi requested a review from l0rd April 28, 2019 07:43
@garagatyi
Copy link
Author

I've merged eclipse-che/che#13204 but since chectl depends on Che wsmaster nightly image we can merge it tomorrow.
@l0rd can you leave you review, so I would be able to proceed with it?

@l0rd l0rd mentioned this pull request May 2, 2019
@garagatyi
Copy link
Author

@l0rd just checked it locally - workspace creation/start works as expected with the current nightly.
I'm ready to merge the PR as soon as you approve it

@garagatyi garagatyi merged commit 3bf6627 into master May 3, 2019
@garagatyi garagatyi deleted the bewPLuginNotation branch May 3, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants