Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Split functionality between server:deploy and server:star commands #990

Merged
merged 4 commits into from
Nov 25, 2020
Merged

feat: Split functionality between server:deploy and server:star commands #990

merged 4 commits into from
Nov 25, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Nov 17, 2020 •
edited
Loading

What does this PR do?

Split functionality between server:deploy and server:star commands

Screenshot/screencast of this PR

./run server:start    
› Current Kubernetes context: 'minikube'
  ✔ Verify Kubernetes API...OK
  ✔ 👀  Looking for an already existing Eclipse Che instance
    ✔ Verify if Eclipse Che is deployed into namespace "che"...it is not
 ›   Warning: Eclipse Che has not been deployed yet. Use server:deploy command to deploy a new Eclipse Che instance.

./run server:deploy --platform minikube   --che-operator-cr-patch-yaml ~/Documents/noupdatepassword.yaml 
› Current Kubernetes context: 'minikube'
› Installer type is set to: 'operator'
  ✔ Verify Kubernetes API...OK
  ✔ 👀  Looking for an already existing Eclipse Che instance
    ✔ Verify if Eclipse Che is deployed into namespace "che"
      ✔ Found running Eclipse Che deployment
      ✔ Found running postgres deployment
      ✔ Found running keycloak deployment
      ✔ Found running plugin registry deployment
      ✔ Found running devfile registry deployment
    ✔ Check Eclipse Che server status...RUNNING (auth enabled)
 ›   Warning: Eclipse Che has been already deployed.

./run server:start    
› Current Kubernetes context: 'minikube'
  ✔ Verify Kubernetes API...OK
  ✔ 👀  Looking for an already existing Eclipse Che instance
    ✔ Verify if Eclipse Che is deployed into namespace "che"
      ✔ Found running Eclipse Che deployment
      ✔ Found running postgres deployment
      ✔ Found running keycloak deployment
      ✔ Found running plugin registry deployment
      ✔ Found running devfile registry deployment
    ✔ Check Eclipse Che server status...RUNNING (auth enabled)
Eclipse Che has been already started.

What issues does this PR fix or reference?

eclipse-che/che#18015

How to test this PR?

  1. Run server:deploy, server:start in a different order

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from l0rd as a code owner November 17, 2020 10:29
@tolusha tolusha marked this pull request as draft November 17, 2020 10:30
This was referenced Nov 17, 2020
Closed
Closed
@tolusha tolusha marked this pull request as ready for review November 24, 2020 10:08
@tolusha tolusha changed the title Split functionality between server:deploy and server:star commands feat: Split functionality between server:deploy and server:star commands Nov 24, 2020
mmorhun
mmorhun approved these changes Nov 24, 2020
View reviewed changes
src/commands/server/start.ts Outdated
import { getCommandFailMessage, getCommandSuccessMessage, initializeContext } from '../../util'

export default class Start extends Command {
static description = 'start Eclipse Che server'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start -> Start ?

src/util.ts Outdated
Comment on lines 178 to 180
* Returns command success message with execution time.
*/
export function getCommandFailMessage(command: Command, ctx: any): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe error message?

yarn.lock
@@ -2134,11 +2134,11 @@ ecc-jsbn@~0.1.1:

"eclipse-che-operator@git://github.com/eclipse/che-operator#master":
version "0.0.0"
resolved "git://github.com/eclipse/che-operator#2e0bfecd456e20e2c289533fe40f05e5c5d78f3e"
resolved "git://github.com/eclipse/che-operator#2e957457f5ab5a9fd370f8915ffedd0c321af240"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update yarn.lock ?

src/common-flags.ts Outdated
Comment on lines 110 to 111
export const LOG_DIRECTORY_KEY = 'directory'
export const directory = string({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is sort of general properties I would like to have logs in prefix

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Nov 24, 2020
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@tolusha
Copy link
Collaborator Author

tolusha commented Nov 25, 2020

/retest

@tolusha
Split functionality between server:deploy and server:start commands
f5859a2 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Fix remarks
2d03500 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Fix imports
d52bba5 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Update yarn.lock
4745227 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented Nov 25, 2020

/retest

@tolusha tolusha merged commit a6d48b1 into master Nov 25, 2020
@tolusha tolusha deleted the serverstart branch November 25, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@flacatus flacatus Awaiting requested review from flacatus

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolusha @openshift-ci-robot @mmorhun