-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add telemetry to track chectl command usage #992
Conversation
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Pending to fix the tests with the new changes |
I have two general remarks.
|
|
Yes, if the description change we will have a new event. Also we can put in the event the command name not the command description |
@davidfestal @l0rd We are thinking to add an additional flag for every command in part to use telemetry. The flag can be something like: |
I think it would be better to have a list of flag that we shouldn't track (like tokens, password, etc.), however I don't know about implementation details here.
I am definitely +1 here.
I think the ID should be the command (e.g. |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
/retest |
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closing in favor of #1052 after for was broken... |
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
This PR introduce to chectl the ability to collect and send to segment commands usage and flags:
Refference issue:eclipse-che/che#18069
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.