Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make workspace commands works for single-user mode #996

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Nov 19, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

It makes workspace commands works for single-user mode

What issues does this PR fix or reference?

eclipse-che/che#18406

How to test this PR?

  1. Deploy Eclipse che in single-user mode chectl server:deploy --platform minikube --installer helm
  2. Use workspace commands

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from mmorhun November 19, 2020 12:44
@tolusha tolusha changed the title Make workspace commands works for single-user mode fix: Make workspace commands works for single-user mode Nov 19, 2020
@AndrienkoAleksandr
Copy link
Contributor

How did I test it:
Installed single user che with patch:

  server:
    customCheProperties:
      CHE_MULTIUSER: "false"

Executed login:

[user@localhost bin]$ ./run auth:login
› Current Kubernetes context: 'minikube'
Using https://che-che.**minikube-ip**.nip.io/api server API URL to log in
Authentication is not supported on the server: "https://che-che.**minikube-ip**.nip.io/api"

Error like expected, because there is no login for single user

Created workspace:

[user@localhost bin]$ ./run workspace:create -f ../devfile.yaml
› Current Kubernetes context: 'minikube'
Workspace has been successfully created:
https://che-che.**minikube-ip**.nip.io/dashboard/#/ide/che/chectl-dev

Got list workspaces:

[user@localhost bin]$ ./run workspace:list
› Current Kubernetes context: 'minikube'
Id                        Name       Namespace Status  Created                  Updated 
workspace0ocq1bww0gb2xuj8 chectl-dev che       STOPPED 2020-11-19T16:27:05.374Z  

Started workspace by id from list:

[user@localhost bin]$ ./run workspace:start workspace0ocq1bww0gb2xuj8
› Current Kubernetes context: 'minikube'
Workspace start request has been sent, workspace will be available shortly:
https://che-che.**minikube-ip**.nip.io/dashboard/#/ide/che/chectl-dev

Stopped workspace:

[user@localhost bin]$ ./run workspace:stop workspace0ocq1bww0gb2xuj8
› Current Kubernetes context: 'minikube'
Workspace successfully stopped.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Nov 23, 2020
@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Nov 23, 2020

@tolusha: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4-chectl-e2e 6a108af link /test v4-chectl-e2e
ci/prow/v5-chectl-e2e 6a108af link /test v5-chectl-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit 5c993e1 into master Nov 25, 2020
@tolusha tolusha deleted the fixauthsingleuser branch November 25, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants