-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make workspace commands works for single-user mode #996
Conversation
How did I test it: server:
customCheProperties:
CHE_MULTIUSER: "false" Executed login: [user@localhost bin]$ ./run auth:login
› Current Kubernetes context: 'minikube'
Using https://che-che.**minikube-ip**.nip.io/api server API URL to log in
Authentication is not supported on the server: "https://che-che.**minikube-ip**.nip.io/api" Error like expected, because there is no login for single user Created workspace: [user@localhost bin]$ ./run workspace:create -f ../devfile.yaml
› Current Kubernetes context: 'minikube'
Workspace has been successfully created:
https://che-che.**minikube-ip**.nip.io/dashboard/#/ide/che/chectl-dev Got list workspaces: [user@localhost bin]$ ./run workspace:list
› Current Kubernetes context: 'minikube'
Id Name Namespace Status Created Updated
workspace0ocq1bww0gb2xuj8 chectl-dev che STOPPED 2020-11-19T16:27:05.374Z Started workspace by id from list: [user@localhost bin]$ ./run workspace:start workspace0ocq1bww0gb2xuj8
› Current Kubernetes context: 'minikube'
Workspace start request has been sent, workspace will be available shortly:
https://che-che.**minikube-ip**.nip.io/dashboard/#/ide/che/chectl-dev Stopped workspace: [user@localhost bin]$ ./run workspace:stop workspace0ocq1bww0gb2xuj8
› Current Kubernetes context: 'minikube'
Workspace successfully stopped. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
6a108af
to
03226c1
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
It makes workspace commands works for single-user mode
What issues does this PR fix or reference?
eclipse-che/che#18406
How to test this PR?
chectl server:deploy --platform minikube --installer helm
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.