Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Olm tests for openshift ci and minikube #998

Merged
merged 5 commits into from
Nov 20, 2020
Merged

feat: Add Olm tests for openshift ci and minikube #998

merged 5 commits into from
Nov 20, 2020

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Nov 19, 2020

What does this PR do?

This PR add additional tests for minikube and Openshift(will be 4.5 4.6 4.7) to test OLM installer.
I add all tests to deploy chectl in namespace eclipse-che
Refference issue: eclipse-che/che#18293

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus flacatus changed the title Olm tests feat: Add Olm tests for openshift ci and minikube Nov 19, 2020
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

flacatus commented Nov 19, 2020

@tolusha @mmorhun @AndrienkoAleksandr
WDYT about renaming gh actions jobs like:
E2E Minikube / OLM installer
E2E Minikube / Helm installer
E2E Minikube / Operator installer
E2E Minishift / Operator installer

@tolusha
Copy link
Collaborator

tolusha commented Nov 19, 2020

I don't mind

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
test/e2e/e2e.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

New tests are created here openshift/release#13771. Pending to merge this PR to have those tests green in OCP ci

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flacatus, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus merged commit 3b55efa into che-incubator:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants