Skip to content
This repository was archived by the owner on Aug 25, 2021. It is now read-only.

WIP Use devfile API #26

Closed
wants to merge 2 commits into from
Closed

WIP Use devfile API #26

wants to merge 2 commits into from

Conversation

sleshchenko
Copy link
Collaborator

@sleshchenko sleshchenko commented Jun 11, 2021

This PR does two stuff:

  • Use Devfile API types instead of declaring itsown;
  • Make DevWorkspaceAPI#Create supply DevWorkspace instead of devfile, to give clients more power. In addition, then we have DevWorkspaceAPI consistent with DevWorkspaceTemplate;

PR is ready to review but should not be merged before Dashboard PR is created and ready to merge. eclipse-che/che-dashboard#272

It fixes eclipse-che/che#19579

@sleshchenko sleshchenko self-assigned this Jun 11, 2021
@sleshchenko sleshchenko force-pushed the useDevfileAPI branch 3 times, most recently from c620e85 to 2e180a7 Compare June 14, 2021 11:36
@sleshchenko sleshchenko marked this pull request as ready for review June 14, 2021 11:55
@sleshchenko sleshchenko requested a review from JPinkney as a code owner June 14, 2021 11:55
@sleshchenko sleshchenko requested review from akurinnoy and olexii4 June 14, 2021 11:55
@sleshchenko
Copy link
Collaborator Author

it's going to be finished on che dashboard end.

@sleshchenko sleshchenko deleted the useDevfileAPI branch August 25, 2021 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @devfile/api types to devworkspace-client
1 participant