Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce devfile for testing purposes #6

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Introduce devfile for testing purposes #6

merged 2 commits into from
Sep 25, 2020

Conversation

vzhukovs
Copy link
Collaborator

This changes proposal adds a devfile with meta.yaml configuration to allow run Intellij Idea as an editor in workspace.

@vzhukovs vzhukovs requested a review from benoitf September 25, 2020 16:16
@vzhukovs vzhukovs self-assigned this Sep 25, 2020
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing eof
Maybe développer workspace button

@vzhukovs
Copy link
Collaborator Author

As for the developer button, we had one (https://che.openshift.io/factory/resources/factory-contribute.svg), I used it in this PR eclipse-theia/theia#7658 but at this moment I couldn't find suitable button image. But agree, it would be nice to have graphical button instead of simple link.

@vzhukovs
Copy link
Collaborator Author

Found suitable button:
Contribute

@vzhukovs vzhukovs merged commit f545f14 into master Sep 25, 2020
@vzhukovs vzhukovs deleted the devfiles branch September 25, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants