-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add support for npm/pnpm workspaces [SIM-130] #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sorccu
wants to merge
15
commits into
main
Choose a base branch
from
simo/sim-130-cli-implement-npm-workspace-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2a9471 to
c6dbc28
Compare
50b11ef to
3bd7f6c
Compare
6 tasks
6 tasks
429f619 to
2cb8499
Compare
This comment has been minimized.
This comment has been minimized.
2cb8499 to
afedd03
Compare
Otherwise workspace packages/files get included with the wrong path.
Did not seem to outright breaking anything, but it was wrong and caused confusion in file lists.
…ith other objects
…ection) Also introduces some debug logs so that you can know what the path is.
de9c3ed to
b32d7ab
Compare
This comment has been minimized.
This comment has been minimized.
Otherwise type brackets can cause errors.
|
🎉 Experimental release successfully published on npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for npm/pnpm workspaces, and other types of project structures where the checkly configuration file is not in the same folder as
package.json.This PR also adds
jsx/tsxsupport since it was crucial for testing workspaces.Affected Components
Notes for the Reviewer
New Dependency Submission