Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umutuzgur/tackle computed alert settings fields #289

Merged
merged 2 commits into from
May 30, 2024

Conversation

umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented May 30, 2024

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

  • Turn TypeSet into TypeList in alert settings and the nested attirubtes in their so TF diff detection uses the position of the value instead of the hash of the value, this doesn't work well with computed values
  • Add computed field to the alert settings fields so client state persists the server defaults

Copy link
Contributor

@Antoine-C Antoine-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@umutuzgur umutuzgur merged commit a284989 into main May 30, 2024
@umutuzgur umutuzgur deleted the umutuzgur/tackle-computed-alert-settings-fields branch May 30, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants