Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) add static ips data source #299

Merged
merged 6 commits into from
Jul 1, 2024
Merged

(feature) add static ips data source #299

merged 6 commits into from
Jul 1, 2024

Conversation

benben
Copy link
Member

@benben benben commented Jul 1, 2024

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • [] Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

shiini2
shiini2 previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@shiini2 shiini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test errors should be fixed once tf new version release is out 🤞

@benben benben requested a review from shiini2 July 1, 2024 11:07
shiini2
shiini2 previously approved these changes Jul 1, 2024
View reviewed changes
@shiini2
Copy link
Contributor

shiini2 commented Jul 1, 2024

Did not test this locally, but as far as I can see, LGTM! Let me know if I should specifically test this

@benben benben requested a review from shiini2 July 1, 2024 11:51
@benben benben merged commit 55b2e08 into main Jul 1, 2024
4 checks passed
@benben benben deleted the ben/add-static-ips-data-source branch July 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiini2 shiini2 shiini2 approved these changes

@maxigimenez maxigimenez Awaiting requested review from maxigimenez maxigimenez is a code owner

@pilimartinez pilimartinez Awaiting requested review from pilimartinez pilimartinez is a code owner

@Antoine-C Antoine-C Awaiting requested review from Antoine-C Antoine-C is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benben @shiini2