fix: allow locations and private_locations to be set to empty lists [sc-23129]
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
requested review from
maxigimenez,
pilimartinez,
Antoine-C and
shiini2
as code owners
Antoine-C
previously approved these changes
Jan 31, 2025
sorccu
force-pushed
the
simokinnunen/sc-23129/checkly-go-sdk-omitempty-for-locations-causes
branch
from
13d7eb9 to
cfd0648
Compare
Previously, applying these values with non-empty lists and then attempting to apply them again with empty lists would keep the previously applied non-empty list due to a JSON serialization oversight.
sorccu
force-pushed
the
simokinnunen/sc-23129/checkly-go-sdk-omitempty-for-locations-causes
branch
from
cfd0648 to
b9d0b21
Compare
sorccu
deleted the
simokinnunen/sc-23129/checkly-go-sdk-omitempty-for-locations-causes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, applying these values with non-empty lists and then attempting to apply them again with empty lists would keep the previously applied non-empty list due to a JSON serialization oversight in the Go SDK and API oddities.
Affected Components
Pre-Requisites
terraform fmtgo fmtplan&applycommand ofdemo/main.tffile do not produce diffsNotes for the Reviewer
New Dependency Submission