Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: backoffice build and deploy #182

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

Vivien-marble
Copy link

@Vivien-marble Vivien-marble commented Aug 4, 2023

working on ci

on: [pull_request]

typescript typecheck and yarn test

if master (not on a tag)

  • typescript typecheck and yarn test
  • build
  • firebase deploy <-- 💥 can't work for now missing secrets.FIREBASE_SERVICE_ACCOUNT

doc used for this PR

firebase documentation about github integration

I (@Vivien-marble) can't:

  • firebase init hosting:github --> missing iam permission to create a service account
  • add the secret FIREBASE_SERVICE_ACCOUNT to gitlab (doc)

@Vivien-marble Vivien-marble force-pushed the vivien/backoffice-ci branch 4 times, most recently from 22f1e4d to 32f9dbe Compare August 4, 2023 14:50
@Vivien-marble Vivien-marble marked this pull request as draft August 4, 2023 14:53
@Vivien-marble Vivien-marble marked this pull request as ready for review August 4, 2023 14:55
@Roukii Roukii force-pushed the vivien/backoffice-ci branch from 32f9dbe to 8b4f6ff Compare August 24, 2023 14:34
@Vivien-marble Vivien-marble force-pushed the vivien/backoffice-ci branch 13 times, most recently from 029d570 to 7ba5ea8 Compare September 8, 2023 14:38
@Pascal-Delange Pascal-Delange temporarily deployed to staging September 8, 2023 15:42 — with GitHub Actions Inactive
@Pascal-Delange
Copy link
Contributor

@Vivien-marble turns out you can't use envinronment secrets (variables are ok) in a reusable workflow actions/runner#1490

@Pascal-Delange Pascal-Delange temporarily deployed to staging September 8, 2023 15:46 — with GitHub Actions Inactive
@Pascal-Delange Pascal-Delange temporarily deployed to staging September 8, 2023 15:51 — with GitHub Actions Inactive
@Pascal-Delange Pascal-Delange force-pushed the vivien/backoffice-ci branch 2 times, most recently from aae25e5 to ceb1dae Compare September 8, 2023 15:58
Vivien-marble and others added 3 commits September 8, 2023 18:02
fix: envinronment secret

Revert "fix: envinronment secret"

This reverts commit 7010ec9.

fix: branch name
@Pascal-Delange Pascal-Delange merged commit 739035f into master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants