complete display of scheduled exec status

checkmarble · Aug 30, 2024 · 95ab7e4 · 95ab7e4
1 parent a44f9f2
commit 95ab7e4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/packages/app-builder/public/locales/en/scheduledExecution.json b/packages/app-builder/public/locales/en/scheduledExecution.json
@@ -12,5 +12,6 @@
   "errors.downloading_decisions_link.unknown": "An unknown error as occured while generating the download link. Please try again later.",
   "status_pending": "Pending",
   "status_success": "Success",
-  "status_failure": "Failure"
+  "status_failure": "Failure",
+  "status_processing": "Processing"
 }
diff --git a/packages/app-builder/src/components/ScheduledExecutions/ScheduledExecutionsList.tsx b/packages/app-builder/src/components/ScheduledExecutions/ScheduledExecutionsList.tsx
@@ -1,4 +1,8 @@
-import { formatDateTime, useFormatLanguage } from '@app-builder/utils/format';
+import {
+  formatDateTime,
+  formatNumber,
+  useFormatLanguage,
+} from '@app-builder/utils/format';
 import { createColumnHelper, getCoreRowModel } from '@tanstack/react-table';
 import clsx from 'clsx';
 import { type ParseKeys } from 'i18next';
@@ -34,9 +38,12 @@ export function ScheduledExecutionsList({
         size: 200,
       }),
       columnHelper.accessor(
-        (s) => (s.status == 'success' ? s.number_of_created_decisions : '0'),
+        (s) => (s.status == 'success' ? s.number_of_created_decisions : 0),
         {
           id: 'number-of-created-decisions',
+          cell: ({ getValue }) => (
+            <span>{formatNumber(getValue(), { language })}</span>
+          ),
           header: t('scheduledExecution:number_of_created_decisions'),
           size: 100,
         },
@@ -127,5 +134,8 @@ const getStatusTKey = (status: string): ParseKeys<['scheduledExecution']> => {
   if (status === 'failure') {
     return 'scheduledExecution:status_failure';
   }
+  if (status === 'processing') {
+    return 'scheduledExecution:status_processing';
+  }
   return 'scheduledExecution:status_pending';
 };
diff --git a/packages/marble-api/openapis/marblecore-api.yaml b/packages/marble-api/openapis/marblecore-api.yaml
@@ -4079,6 +4079,7 @@ components:
           type: string
         status:
           type: string
+          enum: ['pending', 'processing', 'success', 'failure']
     CreateDecisionBody:
       type: object
       required:

diff --git a/packages/marble-api/src/generated/marblecore-api.ts b/packages/marble-api/src/generated/marblecore-api.ts
@@ -245,7 +245,7 @@ export type ScheduledExecution = {
     scenario_name: string;
     scenario_trigger_object_type: string;
     started_at: string;
-    status: string;
+    status: "pending" | "processing" | "success" | "failure";
 };
 export type UploadLog = {
     started_at: string;