Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing the scope of the variables #329

Closed
xemul opened this issue Jun 29, 2017 · 9 comments
Closed

Reducing the scope of the variables #329

xemul opened this issue Jun 29, 2017 · 9 comments
Labels
coverity/codacy enhancement good-first-issue no-auto-close Don't auto-close as a stale issue

Comments

@xemul
Copy link
Member

xemul commented Jun 29, 2017

https://www.codacy.com/app/xemul/criu/issues?bid=4795042&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W251bGxdfSx7ImlkIjoiQ2F0ZWdvcnkiLCJ2YWx1ZXMiOlsiQ29kZSBTdHlsZSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltudWxsXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOlsyMTg5XX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W251bGxdfSx7InZhbHVlcyI6W119XQ==
avagin pushed a commit that referenced this issue Mar 17, 2019
@avagin
action-scripts: Reducing scope of variables
80953e9 
#329

Signed-off-by: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
Signed-off-by: Andrei Vagin <avagin@gmail.com>
avagin pushed a commit to avagin/criu that referenced this issue Apr 16, 2019
@avagin
action-scripts: Reducing scope of variables
d6be0e5 
checkpoint-restore#329

Signed-off-by: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
Signed-off-by: Andrei Vagin <avagin@gmail.com>
avagin pushed a commit that referenced this issue Apr 21, 2019
@avagin
action-scripts: Reducing scope of variables
79fbdb9 
#329

Signed-off-by: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
Signed-off-by: Andrei Vagin <avagin@gmail.com>
@prakritigoyal19 prakritigoyal19 mentioned this issue May 15, 2020
Closed
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue May 23, 2020
@prakritigoyal19
Fixes checkpoint-restore#329: reduce scope of the variable ret (2)
98048d0 
Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 1, 2020
@prakritigoyal19
Reduce scope of integer variable ret
5e892b8 
Fix issue checkpoint-restore#329

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 4, 2020
@prakritigoyal19
Reduce scope of integer variable ret
5180d81 
Fix issue checkpoint-restore#329
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 4, 2020
@prakritigoyal19
Reduce scope of integer variable ret
9c39cbf 
Fix issue checkpoint-restore#329

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 4, 2020
@prakritigoyal19
Reduce scope of integer variable ret
1101bbf 
Fix issue checkpoint-restore#329

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 4, 2020
@prakritigoyal19
Reduce scope of integer variable ret
ca3f803 
Fix issue checkpoint-restore#329

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
prakritigoyal19 added a commit to prakritigoyal19/criu that referenced this issue Jun 7, 2020
@prakritigoyal19
Reduce scope of integer variable ret
ed87ef1 
Fix issue checkpoint-restore#329

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@avagin avagin removed the stale-issue label Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot closed this as completed Apr 4, 2022
@mihalicyn mihalicyn added no-auto-close Don't auto-close as a stale issue good-first-issue and removed stale-issue labels Mar 13, 2023
@mihalicyn mihalicyn reopened this Mar 13, 2023
@mihalicyn
Copy link
Member

https://app.codacy.com/gh/mihalicyn/criu/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W119LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6W119LHsiaWQiOiJMZXZlbCIsInZhbHVlcyI6W119LHsiaWQiOiJQYXR0ZXJuIiwidmFsdWVzIjpbIjIxODkiXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W119XQ==

@warusadura
Copy link
Member

@mihalicyn I'm working on this :)

@mihalicyn
Copy link
Member

@mihalicyn I'm working on this :)

it's better to finish your previous PR #2114 ;-)

@warusadura
Copy link
Member

@mihalicyn will do, I'm a bit stuck with understanding the Python pty and defending my proposed changes :)

@mihalicyn
Copy link
Member

@mihalicyn will do, I'm a bit stuck with understanding the Python pty and defending my proposed changes :)

Well, that doesn't mean you have to quit doing it, right? That's a normal part of development process.
Feel free to ask specific questions, feel free to experiment with your changes :)

GSoC project is not easier and during your work on GSoC problem you will also need to defend your changes and come through technical problems.

@warusadura
Copy link
Member

warusadura commented Mar 13, 2023 •
edited
Loading

@mihalicyn Understood, thanks. I haven't dropped working on #2114 at all :) I just saw/received the notification for this issue and thought "this is an easy fix and I should work on this as well" :)

@mihalicyn
Copy link
Member

Let's close it for now. There are some concerns about rebase issues after changes like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coverity/codacy enhancement good-first-issue no-auto-close Don't auto-close as a stale issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mihalicyn @avagin @xemul @warusadura