Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Add templates for new issues and pull requests #1489

Merged

Conversation

Snorch
Copy link
Member

@Snorch Snorch commented May 29, 2021

This way users would be able to create more meaningfull pull-requests
and issues. And we would not need to ask them to provide basic
information each time.

Signed-off-by: Pavel Tikhomirov ptikhomirov@virtuozzo.com

@Snorch
Copy link
Member Author

Snorch commented May 29, 2021

See how it looks here Snorch#2

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #1489 (58e4a75) into criu-dev (2402192) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 58e4a75 differs from pull request most recent head 112aa53. Consider uploading reports for the commit 112aa53 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           criu-dev    #1489      +/-   ##
============================================
- Coverage     68.72%   68.64%   -0.08%     
============================================
  Files           133      133              
  Lines         32396    32400       +4     
============================================
- Hits          22264    22242      -22     
- Misses        10132    10158      +26     
Impacted Files Coverage Δ
criu/kerndat.c 56.78% <0.00%> (-0.29%) ⬇️
criu/arch/x86/crtools.c 65.39% <0.00%> (-4.10%) ⬇️
compel/arch/x86/src/lib/cpu.c 75.36% <0.00%> (-2.90%) ⬇️
criu/uffd.c 79.36% <0.00%> (-0.39%) ⬇️
criu/cr-restore.c 66.07% <0.00%> (-0.20%) ⬇️
criu/arch/x86/cpu.c 75.33% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2402192...112aa53. Read the comment docs.

@Snorch Snorch force-pushed the templates-for-issues-and-pr branch from fe0e26c to d47fa5f Compare May 30, 2021 07:35
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE.md Show resolved Hide resolved
@Snorch Snorch force-pushed the templates-for-issues-and-pr branch from d47fa5f to 3ff777d Compare May 31, 2021 07:19
@Snorch Snorch force-pushed the templates-for-issues-and-pr branch 3 times, most recently from 785bb6e to 112aa53 Compare May 31, 2021 07:32
This way users would be able to create more meaningfull pull-requests
and issues. And we would not need to ask them to provide basic
information each time.

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
@Snorch Snorch force-pushed the templates-for-issues-and-pr branch from 112aa53 to 5c60a18 Compare May 31, 2021 15:46
@Snorch
Copy link
Member Author

Snorch commented May 31, 2021

Found ; in place of : - fixed.

Copy link
Member

@0x7f454c46 0x7f454c46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this idea in my mind, thanks for adding this!

@avagin avagin merged commit 6d059ff into checkpoint-restore:criu-dev Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants